Draft
Conversation
- Report class similar to that of LOCO's - Part of the efforts of moving the AC ORM measurement to a script - The script will carry out the measurement and launch the analysis and the report. - report will contain basic info about tthe measurement as well as the key analysis we use to access the measurement quality: scale factors, correlation residue and particular columns comparison
- to a new `resources` directory in apsuite's root
- introduces a `show_fig` arg to all the plotting functions - this allows to set it to False, supressing the `fig.show()` command when running analysis - useful for using these functions when runnning the new report class, where we want to generate the figures and save them, but don't want to display the figures
- propagates changes from last commit to the report class: `show_fig=False` - also makes sure all figures are closed after opened (if running on a Jupyter notebook fiugres can still be shown)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage example:
from a preexisting
meas_orm = MeasACORM()object with measurement data loaded, you can generate the analysis and the report withwhich will save the png files and the report pdf at the
reportsdirectory.Many adjustments are yet missing. Work in progress